Eliaaazzz commented on PR #37965: URL: https://github.com/apache/beam/pull/37965#issuecomment-4186190339
> I'm not sure we can do this safely without potentially impacting performance of portable runners which do implement SDF; so I'm a bit worried about taking this Thanks, that makes sense. I agree that enabling this in the default pre-optimization path is too broad if it may impact runners that already support SDF well. I’ll scope this down to the opt-in path only by dropping the default `expand_sdf` change and keeping only explicit `pre_optimize=expand_sdf` support together with the related tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
