arunpandianp commented on code in PR #38139:
URL: https://github.com/apache/beam/pull/38139#discussion_r3066038142
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/TriggerStateMachineRunner.java:
##########
@@ -59,7 +59,7 @@
public class TriggerStateMachineRunner<W extends BoundedWindow> {
@VisibleForTesting
public static final StateTag<ValueState<BitSet>> FINISHED_BITS_TAG =
- StateTags.makeSystemTagInternal(StateTags.value("closed",
BitSetCoder.of()));
+ StateTags.makeSystemTagInternal(StateTags.value("closed",
SentinelBitSetCoder.of()));
Review Comment:
Addressed in the other comment. I think it might be possible, but this PR
does not change semantics due to the clear() in persistFinishedSet().
For GlobalWindow + AfterProcessingTime trigger looks like state might
already be growing unbounded.
https://github.com/apache/beam/blob/6dd599cf3f6b40efd44fa8c084c82ca40353a051/runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/AfterDelayFromFirstElementStateMachine.java#L232
sets the trigger finished bit and it doesn't look like that'll get cleared
anytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
