tkaymak commented on PR #38212: URL: https://github.com/apache/beam/pull/38212#issuecomment-4259913433
If the file `SparkGroupAlsoByWindowViaWindowSet.java` is to remain shared, the current implementation is likely the best way to handle the cross-version compatibility issue without over-engineering. If we prefer a cleaner implementation for Spark 4 at the cost of file duplication (or creating a version adapter), I can move the file and refactor it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
