ahmedabu98 commented on PR #38194: URL: https://github.com/apache/beam/pull/38194#issuecomment-4262027333
Thanks for the helpful breakdown @sachinnn99! I think either way works really. I personally prefer having a concrete `convertLogicalType` method for LogicalType handling, makes it easier to follow where things are. If we go with (1) we can also just remove the existing Java time handling in Avro's `convertDefault`. But there's no wrong solution here, I'll leave it up to your judgement as the PR author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
