bambadiouf1 commented on code in PR #37377:
URL: https://github.com/apache/beam/pull/37377#discussion_r3127889142
##########
sdks/go/pkg/beam/runners/dataflow/dataflow.go:
##########
@@ -61,9 +61,11 @@ var (
numWorkers = flag.Int64("num_workers", 0, "Number of
workers (optional).")
workerHarnessThreads = flag.Int64("number_of_worker_harness_threads",
0, "The number of threads per each worker harness process (optional).")
maxNumWorkers = flag.Int64("max_num_workers", 0, "Maximum
number of workers during scaling (optional).")
- diskSizeGb = flag.Int64("disk_size_gb", 0, "Size of root
disk for VMs, in GB (optional).")
- diskType = flag.String("disk_type", "", "Type of root
disk for VMs (optional).")
- autoscalingAlgorithm = flag.String("autoscaling_algorithm", "",
"Autoscaling mode to use (optional).")
+ diskSizeGb = flag.Int64("disk_size_gb", 0, "Size of
root disk for VMs, in GB (optional).")
+ diskType = flag.String("disk_type", "", "Type of
root disk for VMs (optional).")
+ diskProvisionedIops = flag.Int64("disk_provisioned_iops", 0,
"Provisioned IOPS for the worker disk (optional).")
+ diskProvisionedThroughputMibps =
flag.Int64("disk_provisioned_throughput_mibps", 0, "Provisioned throughput in
MiB/s for the worker disk (optional).")
Review Comment:
Thanks for catching that, Danny! I've added the IOPS and throughput fields
to the WorkerPool. I also updated the `google.golang.org/api` dependency to the
latest version, using ` go get google.golang.org/api@latest` so these fields
are available. It seems like the other required dependencies were updated for
compatibility as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
