Abacn commented on code in PR #37788:
URL: https://github.com/apache/beam/pull/37788#discussion_r3131887315
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1546,22 +1546,15 @@ class BeamModulePlugin implements Plugin<Project> {
"PreferJavaTimeOverload",
"NonCanonicalType",
"Slf4jSignOnlyFormat",
- "ThreadPriorityCheck",
"UndefinedEquals",
"UnescapedEntity",
"UnrecognisedJavadocTag",
// errorprone 3.2.0+ checks
"DirectInvocationOnMock",
- "Finalize",
"JUnitIncompatibleType",
"MockNotUsedInProduction",
- "NullableTypeParameter",
"NullableWildcard",
"SuperCallToObjectMethod",
- // intended suppressions emerged in newer protobuf versions
Review Comment:
> this is only suppression but enabling it will help resolving future issues.
Can we add this comment back
```
// intended suppressions emerged in newer errorprone versions
```
or
```
intended suppressions with justifications
```
The suppression below this line were preferred for performance/backward
compatibility or other reasons that may affect actual functionality and not
merely code style issue
In case future "fix" on these suppressions may introduce unwanted change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
