gemini-code-assist[bot] commented on code in PR #38317:
URL: https://github.com/apache/beam/pull/38317#discussion_r3161561940
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -1392,14 +1392,16 @@ def _add_argparse_args(cls, parser):
'--setup_file',
default=None,
help=(
- 'Path to a setup Python file containing package dependencies. If '
- 'specified, the file\'s containing folder is assumed to have the '
- 'structure required for a setuptools setup package. The file must '
- 'be named setup.py. More details: '
- 'https://pythonhosted.org/an_example_pypi_project/setuptools.html '
- 'During job submission a source distribution will be built and '
- 'the worker will install the resulting package before running any '
- 'custom code.'))
+ 'Path to a file in that defines a Python package that needs to be '
Review Comment:
There is a typo in the help text: 'in that' should be 'that'.
```suggestion
'Path to a file that defines a Python package that needs to be '
```
##########
setup.py:
##########
@@ -0,0 +1,8 @@
+"""An optional setuptools configuration stub for the pipeline package.
+
+Use pyproject.toml to define the package. Add this file if you must
+use the --setup_file pipeline option on Beam 2.59.0 or earlier.
+"""
+
+import setuptools
+setuptools.setup()
Review Comment:
This file appears to have been added to the repository root by mistake. The
`juliaset` example already contains its own `setup.py` in its specific
directory (`sdks/python/apache_beam/examples/complete/juliaset/setup.py`).
Adding a generic `setup.py` to the root of the repository is likely unintended
and should be removed.
##########
website/www/site/content/en/documentation/sdks/python-pipeline-dependencies.md:
##########
@@ -108,7 +108,7 @@ Often, your pipeline code spans multiple files. To run your
project remotely, yo
# List Python packages your pipeline depends on.
]
-2. If your package requires if some programmatic configuration, or you need to
use the `--setup_file` pipeline option, create a setup.py file for your project.
+2. If your package requires if some programmatic configuration, or you need to
use the `--setup_file` pipeline option on Beam SDK 2.59.0 or earlier, create a
setup.py file for your project.
Review Comment:
There is a typo in this line: 'requires if some' should be 'requires some'.
```suggestion
2. If your package requires some programmatic configuration, or you need to
use the `--setup_file` pipeline option on Beam SDK 2.59.0 or earlier, create a
setup.py file for your project.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
