gemini-code-assist[bot] commented on code in PR #38319: URL: https://github.com/apache/beam/pull/38319#discussion_r3161623569
########## sdks/python/apache_beam/testing/analyzers/README.md: ########## @@ -58,7 +57,7 @@ test_1: **NOTE**: `test_target` is optional. It is used for identifying the test that was causing the regression. -**Note**: If the source is **BigQuery**, the `metrics_dataset`, `metrics_table`, `project` and `metric_name` should match with the values defined for performance/load tests. +**Note**: By default, the tool fetches metrics from BigQuery tables. `metrics_dataset`, `metrics_table`, `project` and `metric_name` should match with the values defined for performance/load tests. Review Comment:  The note mentions `metric_name` as a field that should match the performance/load test values, but this field is missing from the example configuration provided in lines 45-50. Consider adding `metric_name` to the example for consistency and clarity. Additionally, the sentence structure can be improved for better readability. ```suggestion **Note**: By default, the tool fetches metrics from BigQuery tables. The `metrics_dataset`, `metrics_table`, `project`, and `metric_name` fields should match the values defined for performance/load tests. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
