reuvenlax commented on PR #38328: URL: https://github.com/apache/beam/pull/38328#issuecomment-4347765984
https://github.com/apache/beam/pull/38332 should address the broken Prism test. On Wed, Apr 29, 2026 at 12:14 PM Reuven Lax ***@***.***> wrote: > If Prism doesn't support window expiration we should fix this - it's quite > a big problem. > > For now, we can modify BigQueryIO to only expand this portion of the graph > if the user has specified schema-update options. That should be a simple > change to make. > > On Wed, Apr 29, 2026 at 12:07 PM Reuven Lax ***@***.***> wrote: > >> GroupIntoBatches also uses OnWindowExpiration. >> >> On Wed, Apr 29, 2026 at 12:03 PM Reuven Lax ***@***.***> wrote: >> >>> Does Prism not support OnWindowExpiration? If so that's a major gap - in >>> many cases there's no way to avoid data loss without OnWindowExpiration. >>> >>> Also, BigQueryIO already used OnWindowExpiration before (e.g. in >>> StorageApiWriteShardedRecords). >>> >>> On Wed, Apr 29, 2026 at 11:48 AM Yi Hu ***@***.***> wrote: >>> >>>> *Abacn* left a comment (apache/beam#38328) >>>> <https://github.com/apache/beam/pull/38328#issuecomment-4346607769> >>>> >>>> Is this caused by #38058 <https://github.com/apache/beam/pull/38058>? >>>> It appears BigQueryIO storage write can no longer run on Direct/Prism >>>> runner. It sounds a regression >>>> >>>> cc: @ahmedabu98 <https://github.com/ahmedabu98> @reuvenlax >>>> <https://github.com/reuvenlax> is it possible to avoid >>>> OnWindowExpiration with some option or, when the runner isn't supported >>>> >>>> — >>>> Reply to this email directly, view it on GitHub >>>> <https://github.com/apache/beam/pull/38328#issuecomment-4346607769>, >>>> or unsubscribe >>>> <https://github.com/notifications/unsubscribe-auth/AFAYJVLRRNOZVCUDZPNX2KD4YJFBRAVCNFSM6AAAAACYLE7DECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGNBWGYYDONZWHE> >>>> . >>>> Triage notifications on the go with GitHub Mobile for iOS >>>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >>>> or Android >>>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >>>> >>>> You are receiving this because you were mentioned.Message ID: >>>> ***@***.***> >>>> >>> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
