gemini-code-assist[bot] commented on code in PR #38236: URL: https://github.com/apache/beam/pull/38236#discussion_r3170084334
########## sdks/python/apache_beam/yaml/yaml_mapping.py: ########## @@ -53,13 +54,13 @@ from apache_beam.yaml.yaml_errors import maybe_with_exception_handling_transform_fn from apache_beam.yaml.yaml_provider import dicts_to_rows Review Comment:  The `schema_from_element_type` function is used in `_PyJsFilter` (line 686) but is not imported. Please add the necessary import from `apache_beam.typehints.schemas`. ```suggestion from apache_beam.typehints.schemas import schema_from_element_type from apache_beam.yaml.yaml_errors import maybe_with_exception_handling_transform_fn from apache_beam.yaml.yaml_provider import dicts_to_rows ``` ########## sdks/python/apache_beam/yaml/yaml_mapping.py: ########## @@ -16,9 +16,10 @@ # """This module defines the basic MapToFields operation.""" + +import datetime import itertools import re -from collections import abc from collections.abc import Callable from collections.abc import Collection from collections.abc import Iterable Review Comment:  The `Mapping` class is used in the `js_to_py` function (line 206) but is not imported. Please add it to the `collections.abc` imports. ```suggestion from collections.abc import Callable from collections.abc import Collection from collections.abc import Iterable from collections.abc import Mapping ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
