gemini-code-assist[bot] commented on code in PR #38360:
URL: https://github.com/apache/beam/pull/38360#discussion_r3174927821
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -2108,7 +2107,6 @@ static class GenerateKafkaSourceDescriptor extends
DoFn<byte[], KafkaSourceDescr
@VisibleForTesting final @Nullable List<String> topics;
private final @Nullable Pattern topicPattern;
- private final @Nullable Boolean logTopicVerification;
Review Comment:
The remaining field declarations in this class (such as `topics` and
`topicPattern`) are scattered after the constructor. For better
maintainability, these should be grouped together at the beginning of the class.
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -2091,7 +2091,6 @@ static class GenerateKafkaSourceDescriptor extends
DoFn<byte[], KafkaSourceDescr
this.topicPattern = read.getTopicPattern();
this.startReadTime = read.getStartReadTime();
this.stopReadTime = read.getStopReadTime();
- this.logTopicVerification = read.getLogTopicVerification();
Review Comment:
The `logTopicVerification` variable and its associated configuration methods
(e.g., `withLogTopicVerification`, `getLogTopicVerification`) likely still
exist in the `KafkaIO.Read` class. If this variable is truly unused across the
entire `KafkaIO` transform, it should also be removed from the `Read` class to
maintain a clean and consistent public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
