ahmedabu98 commented on code in PR #38315:
URL: https://github.com/apache/beam/pull/38315#discussion_r3196547307
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillKeyedWorkItem.java:
##########
@@ -148,18 +150,28 @@ public Iterable<TimerData> timersIterable() {
* drain happened upstream
*/
CausedByDrain drainingValueFromUpstream = CausedByDrain.NORMAL;
+ ValueKind valueKind = ValueKind.INSERT;
if (WindowedValues.WindowedValueCoder.isMetadataSupported()) {
BeamFnApi.Elements.ElementMetadata elementMetadata =
WindmillSink.decodeAdditionalMetadata(windowsCoder,
message.getMetadata());
drainingValueFromUpstream =
elementMetadata.getDrain() ==
BeamFnApi.Elements.DrainMode.Enum.DRAINING
? CausedByDrain.CAUSED_BY_DRAIN
: CausedByDrain.NORMAL;
+ valueKind = ValueKindUtil.fromProto(elementMetadata.getValueKind());
}
InputStream inputStream = message.getData().newInput();
ElemT value = valueCoder.decode(inputStream, Coder.Context.OUTER);
return WindowedValues.of(
- value, timestamp, windows, paneInfo, null, null,
drainingValueFromUpstream, null);
+ value,
+ timestamp,
+ windows,
+ paneInfo,
+ null,
+ null,
+ drainingValueFromUpstream,
+ null,
+ valueKind);
Review Comment:
Added test and ended both with tests with `setMetadataNotSupported()`
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillKeyedWorkItem.java:
##########
@@ -148,18 +150,28 @@ public Iterable<TimerData> timersIterable() {
* drain happened upstream
*/
CausedByDrain drainingValueFromUpstream = CausedByDrain.NORMAL;
+ ValueKind valueKind = ValueKind.INSERT;
if (WindowedValues.WindowedValueCoder.isMetadataSupported()) {
BeamFnApi.Elements.ElementMetadata elementMetadata =
WindmillSink.decodeAdditionalMetadata(windowsCoder,
message.getMetadata());
drainingValueFromUpstream =
elementMetadata.getDrain() ==
BeamFnApi.Elements.DrainMode.Enum.DRAINING
? CausedByDrain.CAUSED_BY_DRAIN
: CausedByDrain.NORMAL;
+ valueKind = ValueKindUtil.fromProto(elementMetadata.getValueKind());
}
InputStream inputStream = message.getData().newInput();
ElemT value = valueCoder.decode(inputStream, Coder.Context.OUTER);
return WindowedValues.of(
- value, timestamp, windows, paneInfo, null, null,
drainingValueFromUpstream, null);
+ value,
+ timestamp,
+ windows,
+ paneInfo,
+ null,
+ null,
+ drainingValueFromUpstream,
+ null,
+ valueKind);
Review Comment:
Added test and ended both tests with `setMetadataNotSupported()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
