jrmccluskey commented on code in PR #37639:
URL: https://github.com/apache/beam/pull/37639#discussion_r3203974559
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -1248,84 +1226,56 @@ def
_verify_interpreter_version_is_supported(pipeline_options):
# is used.
structured_counter_translations = {
cy_combiners.CountCombineFn: (
- dataflow.CounterMetadata.KindValueValuesEnum.SUM,
- MetricUpdateTranslators.translate_scalar_counter_int),
+ 'Sum', MetricUpdateTranslators.translate_scalar_counter_int),
Review Comment:
On further inspection, this is somewhat tied to the fact that the python
client library doesn't use things like CounterUpdate, instead packing
everything into MetricUpdate. This isn't necessarily wrong, but it does make me
somewhat concerned that these legacy combiners may not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
