gemini-code-assist[bot] commented on code in PR #38418:
URL: https://github.com/apache/beam/pull/38418#discussion_r3210190436


##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java:
##########
@@ -83,6 +83,7 @@ public void testMetadataPropagationAcrossShuffleParameter() {
   @Test
   @Category({ValidatesRunner.class, NeedsRunner.class})
   public void testMetadataPropagationParameter() {
+    WindowedValues.WindowedValueCoder.setMetadataSupported();

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The class name should be `WindowedValue` (singular) and the 
`setMetadataSupported` method requires a boolean argument (e.g., `true`). 
Additionally, this method is typically called on `WindowedValue` directly 
rather than the coder inner class. Note that modifying global static state in a 
test can lead to side effects in other tests; consider resetting this state 
after the test execution.
   
   ```suggestion
       WindowedValue.setMetadataSupported(true);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to