gemini-code-assist[bot] commented on code in PR #38437:
URL: https://github.com/apache/beam/pull/38437#discussion_r3218088966
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java:
##########
@@ -83,6 +83,7 @@ public void testMetadataPropagationAcrossShuffleParameter() {
@Test
@Category({ValidatesRunner.class, NeedsRunner.class})
public void testMetadataPropagationParameter() {
+ WindowedValues.WindowedValueCoder.setMetadataSupported();
Review Comment:
The class name `WindowedValues` appears to be a typo for `WindowedValue`.
This will likely cause a compilation error as the standard Beam class is
`WindowedValue`.
```suggestion
WindowedValue.WindowedValueCoder.setMetadataSupported();
```
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java:
##########
@@ -83,6 +83,7 @@ public void testMetadataPropagationAcrossShuffleParameter() {
@Test
@Category({ValidatesRunner.class, NeedsRunner.class})
public void testMetadataPropagationParameter() {
+ WindowedValues.WindowedValueCoder.setMetadataSupported();
Review Comment:
Setting global static state within a `ValidatesRunner` test can lead to test
interference and flakes in other tests. Since this test is part of a suite that
may run in parallel or in a shared JVM, consider using a setup/teardown
mechanism (like `@Before` and `@After`) to ensure the state is properly
initialized and reset, maintaining test isolation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
