scwhittle commented on code in PR #38407: URL: https://github.com/apache/beam/pull/38407#discussion_r3219181214
########## sdks/python/apache_beam/utils/byte_limited_queue.py: ########## @@ -0,0 +1,96 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""A thread-safe queue that limits capacity by total byte size.""" + +import queue +import time +from typing import Any +from typing import Callable + + +class ByteLimitedQueue(queue.Queue): + """A queue.Queue that limits by both element count and total weight. + + A single element is allowed to exceed the maxweight to avoid deadlock. + Note that shutdown is only supported after there are no more put calls. Review Comment: I changed to not subclass queue.Queue. We weren't using the interface and relying overriding some of internals was messy, in particular with shutdown which was added within the range of python versions beam supports. I also wanted the queue to be fair for reasons above. I removed shutdown and changed the test to use a poison pill like data_plane does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
