Abacn commented on code in PR #38438:
URL: https://github.com/apache/beam/pull/38438#discussion_r3230934756
##########
sdks/go/test/integration/io/xlang/jdbc/jdbc_test.go:
##########
@@ -60,8 +59,8 @@ func setupTestContainer(ctx context.Context, t *testing.T,
dbname, username, pas
}
hostname := "localhost"
- dbURL := func(host string, port nat.Port) string {
- return fmt.Sprintf("postgres://%s:%s@%s:%s/%s?sslmode=disable",
username, password, host, port.Port(), dbname)
+ dbURL := func(host string, port string) string {
Review Comment:
not sure if related, it appears this broke TestJDBCIO_PostgresReadWrite
GoUsingJava test:
```
jdbc_test.go:126: failed to start container with 5 retries: All attempts
fail:
#1: start container: started hook: wait until ready: context
deadline exceeded
#2: start container: started hook: wait until ready: get state: Get
"http://%2Frun%2Fdocker.sock/v1.43/containers/9d07c49c38874dfef3c1ceba5166536ebd6f5f62a8ee3b49bde2d094630bb518/json":
context deadline exceeded
#3: start container: started hook: wait until ready: context
deadline exceeded
#4: start container: started hook: wait until ready: context
deadline exceeded
#5: start container: started hook: wait until ready: get state: Get
"http://%2Frun%2Fdocker.sock/v1.43/containers/e9142feec49e30a9b37b0e1807808cc346c5ba8ac61f3b9f5c5a537081752bb9/json":
context deadline exceeded
--- FAIL: TestJDBCIO_PostgresReadWrite (28.98s)
```
#30602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
