tkaymak commented on code in PR #38255: URL: https://github.com/apache/beam/pull/38255#discussion_r3236477251
########## CHANGES.md: ########## @@ -60,7 +60,6 @@ ## Highlights * New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)). -* New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)). Review Comment: Restored the placeholder Java SDK line in #38489. Sorry for the rebase noise. ########## .github/trigger_files/beam_PreCommit_Java_Spark4_Versions.json: ########## @@ -0,0 +1,3 @@ +{ + "comment": "Modify this file in a trivial way to cause this test suite to run" Review Comment: Deleted both trigger files in #38489. Note that since this comment, #38478 renamed the `Spark4StructuredStreaming` ValidatesRunner workflow to `beam_PostCommit_Java_ValidatesRunner_Spark4.yml`, so the second trigger JSON is now doubly orphaned. Left the renamed workflow YAML in place — happy to add a stub trigger JSON for it if you'd prefer, but my read of your guidance on #38453 is that we don't add those for new workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
