reuvenlax commented on code in PR #38363:
URL: https://github.com/apache/beam/pull/38363#discussion_r3249735333
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleDoFnRunnerFactory.java:
##########
@@ -68,17 +67,6 @@ public DoFnRunner<InputT, OutputT> createRunner(
windowingStrategy,
doFnSchemaInformation,
sideInputMapping);
- boolean hasStreamingSideInput =
- options.as(StreamingOptions.class).isStreaming() &&
!sideInputReader.isEmpty();
- if (hasStreamingSideInput) {
- return new StreamingSideInputDoFnRunner<>(
- fnRunner,
- new StreamingSideInputFetcher<>(
- sideInputViews,
- inputCoder,
- windowingStrategy,
- (StreamingModeExecutionContext.StreamingModeStepContext)
userStepContext));
- }
return fnRunner;
Review Comment:
yes - previously we did not support timers in conjunction with side inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
