gemini-code-assist[bot] commented on code in PR #38589:
URL: https://github.com/apache/beam/pull/38589#discussion_r3283391673
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -117,13 +117,12 @@ private GrpcWindmillStreamFactory(
this.streamingRpcBatchLimit = streamingRpcBatchLimit;
this.windmillMessagesBetweenIsReadyChecks =
windmillMessagesBetweenIsReadyChecks;
// Configure backoff to retry calls forever, with a maximum sane retry
interval.
- this.grpcBackOff =
+ Supplier<FluentBackoff> backoffConfig =
Suppliers.memoize(
- () ->
- FluentBackoff.DEFAULT
- .withInitialBackoff(MIN_BACKOFF)
- .withMaxBackoff(maxBackOffSupplier.get())
- .backoff());
+ () -> FluentBackoff.DEFAULT
+ .withInitialBackoff(MIN_BACKOFF)
+ .withMaxBackoff(maxBackOffSupplier.get()));
+ this.grpcBackOff = () -> backoffConfig.get().backoff();
Review Comment:
The indentation of the newly added code is inconsistent with the surrounding
code and the project's style. Continuation lines and lambda bodies should be
properly indented (typically using a 4-space increment for each level).
```suggestion
Supplier<FluentBackoff> backoffConfig =
Suppliers.memoize(
() ->
FluentBackoff.DEFAULT
.withInitialBackoff(MIN_BACKOFF)
.withMaxBackoff(maxBackOffSupplier.get()));
this.grpcBackOff = () -> backoffConfig.get().backoff();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
