gemini-code-assist[bot] commented on code in PR #38700:
URL: https://github.com/apache/beam/pull/38700#discussion_r3307524606
##########
sdks/python/container/boot.go:
##########
@@ -190,12 +190,12 @@ func launchSDKProcess() error {
experiments := getExperiments(options)
logger.Printf(ctx, "Experiments=%v", experiments)
- pipNoBuildIsolation = false
- if slices.Contains(experiments, "pip_no_build_isolation") {
- pipNoBuildIsolation = true
- logger.Printf(ctx, "Build isolation disabled when installing
packages with pip")
- } else {
+ pipNoBuildIsolation = true
+ if slices.Contains(experiments, "pip_use_build_isolation") {
+ pipNoBuildIsolation = false
logger.Printf(ctx, "Build isolation enabled when installing
packages with pip")
+ } else {
+ logger.Printf(ctx, "Build isolation disabled when installing
packages with pip")
}
Review Comment:
The logic can be simplified by directly assigning the boolean expression to
`pipNoBuildIsolation` and then branching on its value. This improves
readability and avoids redundant assignments.
```go
pipNoBuildIsolation = !slices.Contains(experiments,
"pip_use_build_isolation")
if pipNoBuildIsolation {
logger.Printf(ctx, "Build isolation disabled when installing
packages with pip")
} else {
logger.Printf(ctx, "Build isolation enabled when installing
packages with pip")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
