scwhittle commented on code in PR #38695:
URL: https://github.com/apache/beam/pull/38695#discussion_r3309853601
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordAction.java:
##########
@@ -104,6 +104,6 @@ public Optional<ProcessContinuation> run(
return Optional.empty();
}
// no new data, finish reading data
- return cancelQueryOnHeartbeat ? Optional.empty() :
Optional.of(ProcessContinuation.resume());
+ return cancelQueryOnHeartbeat ? Optional.of(ProcessContinuation.resume())
: Optional.empty();
Review Comment:
This auto-analysis is incorrect. Returning empty means that processing will
continue with the current bundle invocation. Returning a non-empty (resume in
this case result) terminates the current processing but will resume at a later
point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
