junaiddshaukat commented on PR #38689:
URL: https://github.com/apache/beam/pull/38689#issuecomment-4554660443
@je-ik I pushed a follow-up addressing your review notes:
- Added KStreamsPayload<T> sum-type envelope so the output channel can
carry both data (WindowedValue) and watermark signals. Kept in-JVM
for now; the Serde lands when the first topic-boundary translator
arrives.
- ImpulseProcessor now emits the data element followed by a terminal
watermark at BoundedWindow.TIMESTAMP_MAX_VALUE. On restart (already
fired) it re-emits the watermark so downstream holds release.
- Replaced the outputs.size() != 1 check with Iterables.getOnlyElement
and added a comment that this is the produced-outputs map (Impulse
always produces one PCollection) — multiple downstream consumers
are modeled as separate PTransforms referencing the same PCollection
id, so they aren't restricted by this.
- Added KafkaStreamsRunnerTest that builds the pipeline via the
high-level Beam SDK (Pipeline.create().apply(Impulse.create())),
extracts the proto, translates, and drives the topology under
TopologyTestDriver.
`./gradlew :runners:kafka-streams:check` green locally
Ready for re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
