gemini-code-assist[bot] commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r3318844147
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -597,7 +597,7 @@ class BeamModulePlugin implements Plugin<Project> {
//
// There are a few versions are determined by the BOMs by running
scripts/tools/bomupgrader.py
// marked as [bomupgrader]. See the documentation of that script for
detail.
- def activemq_version = "5.19.2"
+ def activemq_version = "6.2.5"
Review Comment:
ActiveMQ 6.x requires Java 17 as a minimum runtime version. Since Apache
Beam still supports and runs tests on Java 8 and Java 11, upgrading
`activemq_version` to `6.2.5` will cause test execution failures (such as
`UnsupportedClassVersionError`) on Java 8 and Java 11 environments.
Please consider restricting the JmsIO tests to only run when the build JDK
is 17 or higher, or verify how Java 8/11 compatibility will be maintained for
the test suite.
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -641,7 +641,7 @@ class BeamModulePlugin implements Plugin<Project> {
def protobuf_version = "4.33.2"
// TODO(https://github.com/apache/beam/issues/37637): Remove this once the
Bom has been updated to at least reach this version
def bigtable_version = "2.73.1"
- def qpid_jms_client_version = "0.61.0"
+ def qpid_jms_client_version = "2.10.0"
Review Comment:
Qpid JMS Client 2.x requires Java 11 as a minimum runtime version. Since
Apache Beam still supports Java 8, upgrading `qpid_jms_client_version` to
`2.10.0` will break Java 8 compatibility for any users or tests utilizing this
client. Please verify if this is intentional or if we need to restrict this
dependency/module to Java 11+.
##########
sdks/java/io/jms/build.gradle:
##########
@@ -32,7 +32,7 @@ dependencies {
implementation project(path: ":sdks:java:core", configuration: "shadow")
implementation library.java.slf4j_api
implementation library.java.joda_time
- implementation "org.apache.geronimo.specs:geronimo-jms_2.0_spec:1.0-alpha-2"
+ implementation "jakarta.jms:jakarta.jms-api:3.1.0"
Review Comment:
`jakarta.jms:jakarta.jms-api:3.1.0` (Jakarta Messaging 3.1) is compiled for
Java 11 (class file version 55.0). Since Apache Beam still supports Java 8,
using version `3.1.0` will break Java 8 compatibility for the
`beam-sdks-java-io-jms` module.
To maintain Java 8 compatibility while migrating to the `jakarta.jms`
namespace, please use `jakarta.jms:jakarta.jms-api:3.0.0` (Jakarta Messaging
3.0), which is compiled for Java 8 (class file version 52.0).
```
implementation "jakarta.jms:jakarta.jms-api:3.0.0"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
