Anuragp22 commented on code in PR #38749:
URL: https://github.com/apache/beam/pull/38749#discussion_r3370729753
##########
sdks/python/apache_beam/metrics/metric.py:
##########
@@ -204,12 +237,17 @@ class DelegatingCounter(Counter):
def __init__(
self, metric_name: MetricName, process_wide: bool = False) -> None:
super().__init__(metric_name)
- self.inc = MetricUpdater( # type: ignore[method-assign]
+ self._updater = MetricUpdater(
cells.CounterCell,
metric_name,
default_value=1,
process_wide=process_wide)
+ def inc(self, n: int = 1) -> None:
Review Comment:
Sorry about this, the regression is mine, and thanks for the quick fix.
For the other breakages you are still seeing, could you point me at the
suite that surfaced them? I will reproduce and take the fixes.
I can also add a regression test covering `inc(value=...)` so this does not
regress again, and open the public PR for the `value` rename if you have not
already pushed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
