gemini-code-assist[bot] commented on code in PR #38879:
URL: https://github.com/apache/beam/pull/38879#discussion_r3384204875


##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -418,9 +418,11 @@
         catalog_properties: 'catalog_properties'
         config_properties: 'config_properties'
         triggering_frequency_seconds: 'triggering_frequency_seconds'
+        manifest_file_size: 'manifest_file_size'

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   When adding new parameters to the `mappings` of an underlying provider, they 
must also be defined in the `properties` schema of the transform (typically 
located above the `underlying_provider` section in this file). If they are 
omitted from the schema, YAML validation will fail when these parameters are 
used in pipelines (such as in the test file). Add `manifest_file_size` (as an 
integer) and `sort_fields` (as an array of strings) to the transform's 
properties schema if they are not already present.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to