Eliaaazzz commented on code in PR #38892:
URL: https://github.com/apache/beam/pull/38892#discussion_r3389362559
##########
sdks/python/apache_beam/io/iobase.py:
##########
@@ -990,9 +998,11 @@ def to_runner_api_parameter(
common_urns.deprecated_primitives.READ.urn,
beam_runner_api_pb2.ReadPayload(
source=self.source.to_runner_api(context),
- is_bounded=beam_runner_api_pb2.IsBounded.BOUNDED
- if self.source.is_bounded() else
- beam_runner_api_pb2.IsBounded.UNBOUNDED))
+ is_bounded=beam_runner_api_pb2.IsBounded.BOUNDED))
Review Comment:
The branch condition is unchanged from master (`isinstance(self.source,
BoundedSource)`), so legacy non-`BoundedSource` sources are unaffected:
`_PubSubSource` keeps its dedicated branch above, and other sources raised
`NotImplementedError` on master as well. The actual delta was a `BoundedSource`
subclass overriding `is_bounded()` to `False`; restored master's conditional in
6e6a40c6d3a.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
