gemini-code-assist[bot] commented on code in PR #38901:
URL: https://github.com/apache/beam/pull/38901#discussion_r3391088504
##########
sdks/python/apache_beam/metrics/metric.py:
##########
@@ -269,23 +231,13 @@ class DelegatingStringSet(StringSet):
"""Metrics StringSet that Delegates functionality to MetricsEnvironment."""
def __init__(self, metric_name: MetricName) -> None:
super().__init__(metric_name)
- self._updater = MetricUpdater(cells.StringSetCell, metric_name)
-
- def add(self, value: str) -> None:
- if MetricsFlag.string_set_disabled:
- return
- self._updater(value)
+ self.add = MetricUpdater(cells.StringSetCell, metric_name) # type:
ignore[method-assign]
class DelegatingBoundedTrie(BoundedTrie):
- """Metrics BoundedTrie that Delegates functionality to
MetricsEnvironment."""
+ """Metrics StringSet that Delegates functionality to MetricsEnvironment."""
Review Comment:
The docstring for `DelegatingBoundedTrie` was incorrectly changed to refer
to `StringSet` instead of `BoundedTrie`. It should be corrected to accurately
describe the class.
```suggestion
"""Metrics BoundedTrie that Delegates functionality to
MetricsEnvironment."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
