arunpandianp commented on code in PR #38921:
URL: https://github.com/apache/beam/pull/38921#discussion_r3396635352
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java:
##########
@@ -216,6 +216,8 @@ public void scheduleWork(
Work.ProcessingContext processingContext,
boolean drainMode,
ImmutableList<LatencyAttribution> getWorkStreamLatencies) {
+ // Before any processing starts, call any pending OnCommit callbacks
+
commitFinalizer.finalizeCommits(workItem.getSourceState().getFinalizeIdsList());
Review Comment:
commitFinalizer.finalizeCommits submits the callbacks to a different
executor and does not execute them inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
