Eliaaazzz commented on PR #38510: URL: https://github.com/apache/beam/pull/38510#issuecomment-4701635226
Thanks for the review. I addressed all the comments: - Removed the unused timezone field. The parser still accepts the timezone argument but ignores it. - A bare DateTime64 now parses and defaults to precision 3. - A bad precision and a typo now both funnel through the same failed to parse error. - Moved the magic numbers in the IT and unit tests into named constants. - Added a nullable DateTime64(9) integration test that writes both a value and a null. - Added overflow and null input tests in the writer test. - Reused a single NanosInstant constant and null-check the precision before unboxing. Let me know if anything else needs a change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
