scwhittle commented on code in PR #38863:
URL: https://github.com/apache/beam/pull/38863#discussion_r3413894185
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundAggregator.java:
##########
@@ -53,10 +55,7 @@
* <p>The default time-based buffer threshold can be overridden by specifying
the experiment {@code
* data_buffer_time_limit_ms=<milliseconds>}
*/
-@SuppressWarnings({
- "nullness" // TODO(https://github.com/apache/beam/issues/20497)
-})
-// The calling thread that invokes sendBufferedDataAndFinishOutboundStreams
synchronizes on
+// The calling thread that invokes
sendOrCollectBufferedDataAndFinishOutboundStreams synchronizes on
Review Comment:
the locking in this class is complicated, the synchronization is just needed
if there is the background flush future. With a single implementation the
duplicated code is at least co-located but we could possibly restructure to two
separate implementations to simplify the non-background flushing implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
