gemini-code-assist[bot] commented on code in PR #38962:
URL: https://github.com/apache/beam/pull/38962#discussion_r3414364945
##########
sdks/python/build.gradle:
##########
@@ -145,12 +145,7 @@ tasks.register("yamlIntegrationTests") {
description "Runs precommit integration tests for yaml pipelines."
dependsOn installGcpTest
- // Need to build all expansion services referenced in apache_beam/yaml/*.*
- // grep -oh 'sdk.*Jar' sdks/python/apache_beam/yaml/*.yaml | sort | uniq
- dependsOn ":sdks:java:extensions:schemaio-expansion-service:shadowJar"
- dependsOn ":sdks:java:extensions:sql:expansion-service:shadowJar"
- dependsOn ":sdks:java:io:expansion-service:build"
- dependsOn ":sdks:java:io:google-cloud-platform:expansion-service:build"
+ dependsOn prepareExpansionServicesForYamlDocs
Review Comment:
Referencing the task `prepareExpansionServicesForYamlDocs` as a bare
identifier can lead to configuration-time errors (such as
`MissingPropertyException`) if the task is registered lazily using
`tasks.register` or defined later in the build script. Using a string literal
`"prepareExpansionServicesForYamlDocs"` ensures that Gradle resolves the
dependency lazily and safely.
```
dependsOn "prepareExpansionServicesForYamlDocs"
```
##########
sdks/python/build.gradle:
##########
@@ -164,12 +159,7 @@ tasks.register("postCommitYamlIntegrationTests") {
description "Runs postcommit integration tests for yaml pipelines -
parameterized by yamlTestSet."
dependsOn installGcpTest
- // Need to build all expansion services referenced in apache_beam/yaml/*.*
- // grep -oh 'sdk.*Jar' sdks/python/apache_beam/yaml/*.yaml | sort | uniq
- dependsOn ":sdks:java:extensions:schemaio-expansion-service:shadowJar"
- dependsOn ":sdks:java:extensions:sql:expansion-service:shadowJar"
- dependsOn ":sdks:java:io:expansion-service:build"
- dependsOn ":sdks:java:io:google-cloud-platform:expansion-service:build"
+ dependsOn prepareExpansionServicesForYamlDocs
Review Comment:
Referencing the task `prepareExpansionServicesForYamlDocs` as a bare
identifier can lead to configuration-time errors (such as
`MissingPropertyException`) if the task is registered lazily using
`tasks.register` or defined later in the build script. Using a string literal
`"prepareExpansionServicesForYamlDocs"` ensures that Gradle resolves the
dependency lazily and safely.
```
dependsOn "prepareExpansionServicesForYamlDocs"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
