Abacn commented on code in PR #38931:
URL: https://github.com/apache/beam/pull/38931#discussion_r3414586821
##########
.github/actions/setup-environment-action/action.yml:
##########
@@ -74,7 +74,7 @@ runs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
- java-version: ${{ inputs.java-version == 'default' && '11' ||
inputs.java-version }}
+ java-version: ${{ inputs.java-version == 'default' &&
((contains(github.job, 'Xlang') || contains(github.job, 'XVR') ||
contains(github.job, 'PreCommit_Java')) && '17' || '11') || inputs.java-version
}}
Review Comment:
This is a valid comment and it indeed caused a couple of tests now failing
We should keep Java artifacts compiled on Java11 by default as it matches
release build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
