ddebowczyk92 commented on code in PR #38961:
URL: https://github.com/apache/beam/pull/38961#discussion_r3427661307


##########
examples/java/common.gradle:
##########
@@ -35,6 +35,16 @@ configurations.sparkRunnerPreCommit {
   exclude group: "org.slf4j", module: "jul-to-slf4j"
   exclude group: "org.slf4j", module: "slf4j-jdk14"
 }
+configurations.flinkRunnerPreCommit {

Review Comment:
   The problem is that Flink 2.1+ comes with `at.yawk.lz4:lz4-java` instead of 
`org.lz4:lz4-java`. This becomes an issue in modules where both libraries are 
present; this change simply favors the former.
   ```
   > Could not resolve org.lz4:lz4-java:1.8.0.
            > Module 'org.lz4:lz4-java' has been rejected:
                 Cannot select module with conflict on capability 
'org.lz4:lz4-java:1.8.0' also provided by 
[at.yawk.lz4:lz4-java:1.10.3(runtimeElements)]
         > Could not resolve at.yawk.lz4:lz4-java:1.10.3.
            > Module 'at.yawk.lz4:lz4-java' has been rejected:
                 Cannot select module with conflict on capability 
'org.lz4:lz4-java:1.10.3' also provided by [org.lz4:lz4-java:1.8.0(runtime)]
    ```
    
   In the case of this specific module, the conflict arises because of the 
`kafka-clients `dependency, which brings in the old version of `org.lz4`.
   
   The parents of the clashing dependencies can be checked via this command:
   `./gradlew :examples:java:dependencies --configuration flinkRunnerPreCommit 
| grep -B2 "org.lz4:lz4-java:1.6.0"`
   
   I made these changes to pass the ` ./gradlew :javaPreCommit` CICD check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to