reuvenlax commented on code in PR #38988:
URL: https://github.com/apache/beam/pull/38988#discussion_r3430124362
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java:
##########
Review Comment:
I think helpers.processTimers already does this
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingKeyedWorkItemSideInputParDoFn.java:
##########
@@ -119,7 +120,9 @@ protected void onStartKey() {
if (sideInputProcessor != null) {
boolean hasState = helpers.hasState();
- // TODO(relax): We should be able to get this without writing it to
state!
+ // TODO(relax): We should be able to get this without writing it to
state! To make this work,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
