gemini-code-assist[bot] commented on code in PR #39007:
URL: https://github.com/apache/beam/pull/39007#discussion_r3431708550
##########
sdks/python/apache_beam/ml/rag/test_utils.py:
##########
@@ -152,9 +153,8 @@ def list_collections_probe():
retry_with_backoff(
list_collections_probe,
- max_retries=25,
+ max_retries=5,
retry_delay=2.0,
Review Comment:
Reducing `max_retries` to 5 with a flat `retry_delay` of 2.0 seconds allows
only 10 seconds for the Milvus container to become ready. In
resource-constrained CI environments (such as GitHub Actions runners), starting
a Milvus standalone container (which includes etcd and MinIO) can frequently
take longer than 10 seconds, potentially leading to flaky test failures.
Consider keeping a higher retry limit (e.g., 15 or 20 retries) or retaining the
backoff factor to ensure sufficient startup time.
```suggestion
max_retries=15,
retry_delay=2.0,
retry_backoff_factor=1.1,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
