utkarshparekh commented on code in PR #39098:
URL: https://github.com/apache/beam/pull/39098#discussion_r3473358569
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/JsonToRowTest.java:
##########
@@ -274,6 +274,31 @@ public void
testParsesErrorWithErrorMsgWithRequireNullDeadLetter() throws Except
pipeline.run();
}
+ @Test
+ @Category(NeedsRunner.class)
+ public void testDownstreamExceptionIsNotReportedAsParseError() {
+ PCollection<String> jsonPersons = pipeline.apply("jsonPersons",
Create.of(JSON_PERSON.get(0)));
+
+ ParseResult results =
jsonPersons.apply(JsonToRow.withExceptionReporting(PERSON_SCHEMA));
+
+ results
+ .getResults()
+ .apply(
+ "throwingDownstream",
+ ParDo.of(
+ new DoFn<Row, Row>() {
+ @ProcessElement
+ public void processElement(ProcessContext context) {
+ throw new RuntimeException("downstream failure");
+ }
+ }));
Review Comment:
the serialization concern is addressed and verified on DirectRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
