je-ik commented on code in PR #39051: URL: https://github.com/apache/beam/pull/39051#discussion_r3482403262
########## sdks/java/build-tools/src/main/resources/beam/checkstyle/suppressions.xml: ########## @@ -56,6 +56,7 @@ <!-- gRPC/protobuf exceptions --> <!-- Non-vendored gRPC/protobuf imports are allowed for files that depend on libraries that expose gRPC/protobuf in its public API --> <suppress id="ForbidNonVendoredGrpcProtobuf" files=".*sdk.*extensions.*protobuf.*" /> + <suppress id="ForbidNonVendoredGrpcProtobuf" files=".*runners.*kafka-streams.*KStreamsPayloadSerde\.java" /> Review Comment: I'm thinking if this is actually correct. Is there a chance we could use trhe vendored version? If anything, we probbaly might relocate the final classes. It might not be critical, because - because we are using the FnAPI the classpath will be physically separated between user code (SDK) and the runner. But it would feel 'safer' if we could use the vendored version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
