jrmccluskey commented on PR #38429: URL: https://github.com/apache/beam/pull/38429#issuecomment-4847233891
I don't particularly love running this on every single output at runtime. While each individual call of `is_instance()` isn't that expensive, over the life of a pipeline that adds up when this would likely be caught on the first element run through the DoFn. My thought is that we _should_ be able to catch this at construction time in some way via existing type checking and/or trivial inference (although I am not thrilled at the idea of making trivial inference any more load bearing than it already is.) I don't immediately have a solution in mind though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
