tkaymak commented on PR #39180: URL: https://github.com/apache/beam/pull/39180#issuecomment-4855699758
Thank you for migrating this over @Abacn - LGTM I think that the password null pointer is worth fixing, as I believe some people might run MQTT without a password in testing envs. Regarding the leakage comments by Gemini - I would leave this to your judgement, but I think they are on point too. The overall code changes are basically library adjustments and look clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
