Abacn commented on code in PR #39253:
URL: https://github.com/apache/beam/pull/39253#discussion_r3548050530
##########
runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java:
##########
@@ -173,16 +173,17 @@ public void processElement(
} else {
Instant watermark = reader.getWatermark();
if (watermark.isBefore(BoundedWindow.TIMESTAMP_MAX_VALUE)) {
- // If the reader had no elements available, but the shard is not
done, reuse it later
- // Might be better to finalize old checkpoint.
+ // If the reader had no elements available, but the shard is not
done, reuse it later.
Review Comment:
in a typical run, 5/6 tests observe small amount of messages are not acked
due to the known issue noted here:
https://github.com/apache/beam/blob/3c28e775ee06080bbab88f175b67549ab82b8471/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java#L211
- testPublishingThenReadingAllClientAcknowledgeUnsafe: 1
- testPublishingThenReadingAllIndividualAcknowledge: 13
- testPublishingThenReadingAllIndividualAcknowledge: 13
- testPublishingThenReadingAll: 34
- testPublishingThenReadingAll: 33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
