Abacn commented on code in PR #39432:
URL: https://github.com/apache/beam/pull/39432#discussion_r3638952338
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/JdbcConnection.java:
##########
@@ -51,11 +51,39 @@ public class JdbcConnection extends
CalciteConnectionWrapper {
private Map<String, String> pipelineOptionsMap;
private @Nullable PipelineOptions pipelineOptions;
+ /**
+ * A mutable, session-scoped operator table that callers can populate with
custom {@link
+ *
org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlOperator}s
after the
+ * connection (and its planner) is built. {@link
CalciteQueryPlanner#defaultConfig} chains this
+ * table at the front of the validator/converter operator table, so
operators added here resolve
+ * in subsequent SQL. This is the channel for functions that must declare a
non-fixed (e.g. {@code
+ * VARIADIC}) operand checker, which the schema-function auto-wrapping in
{@code
+ * CalciteCatalogReader.toOp} (always fixed-parameter {@code
OperandMetadataImpl}) cannot express.
+ * The list is held by reference in the planner config, so additions made
after the planner is
+ * built are visible.
+ */
+ private final
org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.util
+ .ListSqlOperatorTable
Review Comment:
(formatting) import the names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
