ahmedabu98 commented on code in PR #39408:
URL: https://github.com/apache/beam/pull/39408#discussion_r3659599835
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergIO.java:
##########
@@ -483,6 +491,26 @@ public WriteRows withWriteProperties(Map<String, String>
writeProperties) {
return toBuilder().setWriteProperties(writeProperties).build();
}
+ /**
+ * Defines the desired Partition Spec to be applied when the Iceberg table
must be dynamically
+ * created, e.g. `bucket(id_field, 32)` or `day(timestamp_field)`
+ *
+ * <p>See: https://iceberg.apache.org/spec/#partitioning
+ */
+ public WriteRows withPartitionSpec(List<String> partitionFields) {
Review Comment:
nit: maybe more accurate to name this `withPartitionFields()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
