stankiewicz commented on code in PR #39625:
URL: https://github.com/apache/beam/pull/39625#discussion_r3720700193
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java:
##########
@@ -606,6 +622,13 @@ public synchronized void publishToDisk(
writeIfNotEmpty(generator, "work", DataflowWorkerLoggingMDC.getWorkId());
writeIfNotEmpty(generator, "logger", record.getLoggerName());
writeIfNotEmpty(generator, "exception",
formatException(record.getThrown()));
+ SpanContext spanContext = Span.current().getSpanContext();
+ if (logOpenTelemetryTraceSpanIdAndSampled.get() &&
spanContext.isValid()) {
+ generator.writeStringField("trace", spanContext.getTraceId());
+ generator.writeStringField("spanId", spanContext.getSpanId());
+ generator.writeBooleanField("traceSampled", spanContext.isSampled());
Review Comment:
on skipping writing - sounds like good idea, will implement that as well.
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java:
##########
@@ -606,6 +622,13 @@ public synchronized void publishToDisk(
writeIfNotEmpty(generator, "work", DataflowWorkerLoggingMDC.getWorkId());
writeIfNotEmpty(generator, "logger", record.getLoggerName());
writeIfNotEmpty(generator, "exception",
formatException(record.getThrown()));
+ SpanContext spanContext = Span.current().getSpanContext();
+ if (logOpenTelemetryTraceSpanIdAndSampled.get() &&
spanContext.isValid()) {
+ generator.writeStringField("trace", spanContext.getTraceId());
+ generator.writeStringField("spanId", spanContext.getSpanId());
+ generator.writeBooleanField("traceSampled", spanContext.isSampled());
Review Comment:
on skipping writing when sampled=false - sounds like good idea, will
implement that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
