kennknowles commented on code in PR #39594:
URL: https://github.com/apache/beam/pull/39594#discussion_r3798719414
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/ModelCoderRegistrar.java:
##########
@@ -136,4 +137,23 @@ public Map<Class<? extends Coder>, String> getCoderURNs() {
public Map<Class<? extends Coder>, CoderTranslator<? extends Coder>>
getCoderTranslators() {
return BEAM_MODEL_CODERS;
}
+
+ @Override
+ public boolean isKnownCoder(Coder<?> coder, PipelineOptions options) {
+ if (coder.getClass() == SchemaCoder.class
+ && !ExperimentalOptions.hasExperiment(options,
"use_known_schema_coder")) {
Review Comment:
I don't think we want to start translating to a different portable pipeline
for different runners, though... seems like the issue in
https://github.com/apache/beam/issues/33859#issuecomment-4462409236 should just
be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
