arunpandianp commented on code in PR #39473:
URL: https://github.com/apache/beam/pull/39473#discussion_r3809185573
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java:
##########
@@ -264,7 +264,7 @@ private void processWork(
handleProcessWorkFailure(
computationState, handle.getWorkBatch(), computationId, systemName,
work, t);
} finally {
- List<Work> processedWorkBatch = workBatch != null ? workBatch :
ImmutableList.of(work);
+ List<Work> processedWorkBatch = workBatch != null ? workBatch :
handle.getWorkBatch();
Review Comment:
good idea, done and removed `executedWorks`. I added `handle.getWorkBatch`
after adding `executedWorks` and didn't think about it to replace
`executedWorks`
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java:
##########
@@ -431,6 +427,8 @@ private void commitMultiKeyWorkBatch(
.build());
}
+ Windmill.MultiKeyWorkItemCommitRequest multiKeyCommitRequest =
multiKeyBuilder.build();
Review Comment:
reverted.
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java:
##########
@@ -4884,6 +4890,395 @@ public void
testSkipInputElementsWithDecodingExceptions() throws Exception {
"12345",
commit.getOutputMessages(0).getBundles(0).getMessages(0).getData().toStringUtf8());
}
+ @Test
+ public void testMultiKeyCommit_batchCommitSizeExceededUnBatchSucceeds()
throws Exception {
+ if (!streamingEngine) {
+ return;
+ }
+ KvCoder<String, String> kvCoder = KvCoder.of(StringUtf8Coder.of(),
StringUtf8Coder.of());
+
+ List<ParallelInstruction> instructions =
+ Arrays.asList(
+ makeSourceInstruction(kvCoder),
+ makeDoFnInstruction(new FixedSizeCommitFn(500), 0, kvCoder),
+ makeSinkInstruction(kvCoder, 1));
+
+ StreamingDataflowWorker worker =
+ makeWorker(
+ defaultWorkerParams(
+
"--experiments=unstable_enable_multi_key_bundle,windmill_max_key_group_batch_time_ms=5000",
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
