shahar1 commented on code in PR #39203: URL: https://github.com/apache/beam/pull/39203#discussion_r3828227575
########## sdks/python/apache_beam/io/gcp/bigquery_tools.py: ########## @@ -358,11 +359,17 @@ class BigQueryWrapper(object): HISTOGRAM_METRIC_LOGGER = MetricLogger() - def __init__(self, client=None, temp_dataset_id=None, temp_table_ref=None): - self.client = client or BigQueryWrapper._bigquery_client(PipelineOptions()) - self.gcp_bq_client = client or gcp_bigquery.Client( - client_info=ClientInfo( - user_agent="apache-beam-%s" % apache_beam.__version__)) + def __init__( + self, + client=None, Review Comment: Done, `BigQueryWrapper` now takes `pipeline_options/quota_project_id` and builds both clients itself, with `lclient/gcp_client` as separate keyword-only test overrides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
