Abacn commented on PR #39367:
URL: https://github.com/apache/beam/pull/39367#issuecomment-5455286062
Sorry for the delay. Finally tested the change on windows machine. After
this change, I now get
```
java.nio.file.InvalidPathException: Illegal char <:> at index 3:
2-0:EMBEDDED-beam-runners-spark-3-2.77.0-SNAPSHOT-tests-zUZNDVnjWePBLRRgVBuQZCUbjm--MDusKXUWfMTxIfM.
at
java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:204)
at
java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:175)
at
java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
at
java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:231)
at java.base/java.nio.file.Path.resolve(Path.java:516)
at
org.apache.beam.sdk.io.LocalResourceId.resolveLocalPathWindowsOS(LocalResourceId.java:106)
at
org.apache.beam.sdk.io.LocalResourceId.resolve(LocalResourceId.java:66)
at
org.apache.beam.sdk.io.LocalResourceId.resolve(LocalResourceId.java:37)
at
org.apache.beam.runners.fnexecution.artifact.ArtifactStagingService$1.getDestination(ArtifactStagingService.java:171)
```
by running `./gradlew
:runners:spark:3:job-server:validatesPortableRunnerBatch --no-daemon --tests
'*ParDoTest$BasicTests' -PdisableSpotlessCheck=true`. On master branch, it
hangs indefinitely.
Ideally we could get the windows path fixed in a follow up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
