Shizuma5 opened a new pull request, #39972:
URL: https://github.com/apache/beam/pull/39972
Fixes #39969
## summary
`fileio.MatchAll` fails to return existing GCS objects when the glob pattern
contains multi-byte characters.
The root cause is in `globToRegex()`.
`globToRegex()` translates a glob pattern into a regular expression, but it
scanned the pattern byte by byte in order to handle wildcards.
As a result, when the pattern contained multibyte characters, the generated
regular expression became corrupted and no longer matched any actual paths.
This behavior was introduced by #38099 in version 2.75.0; earlier versions
used the rune-aware `filepath.Match`, so version 2.74.0 and earlier are
unaffected.
This PR makes `globToRegex()` scan the pattern rune by rune, so glob
patterns containing multi-byte characters can be used.
## tests
Added multi-byte cases to TestGlobToRegex (e.g. résumé.txt, résumé/*.txt,
*/résumé.txt). They fail on master and pass with this change.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
