ahmedabu98 commented on code in PR #39973:
URL: https://github.com/apache/beam/pull/39973#discussion_r3927459746
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/SerializableDeleteFile.java:
##########
@@ -228,7 +282,21 @@ public DeleteFile createDeleteFile(
.withMetrics(metrics)
.withSplitOffsets(getSplitOffsets())
.withEncryptionKeyMetadata(getKeyMetadata())
- .withPartitionPath(getPartitionPath());
+ .withReferencedDataFile(getReferencedDataFile());
+
+ @Nullable String jsonPartition = getJsonPartition();
+ if (jsonPartition != null) {
+ try {
+ deleteFileBuilder =
deleteFileBuilder.withPartition(partition(partitionSpec));
+ } catch (RuntimeException e) {
Review Comment:
Underlying utils throw different types of RuntimeExceptions (see similar
comment here(https://github.com/apache/beam/pull/39705#discussion_r3762465377))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
